REF: handle axis=None case inside DataFrame.any/all to simplify _reduce #35899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/frame.py
Outdated
|
|
||
| def func(values): | ||
| if is_extension_array_dtype(values.dtype): | ||
| return extract_array(values)._reduce(name, skipna=skipna, **kwds) | ||
| else: | ||
| return op(values, axis=axis, skipna=skipna, **kwds) | ||
|
|
||
| def _get_data(axis_matters): | ||
| def _get_data(axis_matters: bool): |
There was a problem hiding this comment.
While we're here could we type that it returns a DataFrame?
|
@jreback gentle ping; long-awaited cleanups to DataFrame._reduce come after this |
jreback
approved these changes
Sep 2, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…ce (pandas-dev#35899) * REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * REF: handle axis=None cases inside DataFrame.all/any * annotate * dummy commit to force Travis Co-authored-by: Karthik Mathur <22126205+mathurk1@users.noreply.github.com> Co-authored-by: tkmz-n <60312218+tkmz-n@users.noreply.github.com>
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between this, #35881, and the PR coming after 35881, we'll be able to simplify _reduce quite a bit.