Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move sql builds from Travis to Github actions #38344

Merged
merged 69 commits into from
Dec 27, 2020

Conversation

fangchenli
Copy link
Member

try to move builds with databases to GitHub actions

@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Dec 10, 2020
@simonjayhawkins
Copy link
Member

marking this as 1.2 as any changes to the CI will also need to be backported. but not a blocker for 1.2.

@jreback
Copy link
Contributor

jreback commented Dec 10, 2020

looks good, @fangchenli can you make the change indicated by @simonjayhawkins merge master and ping on green (possible numpy-dev is still failing but that's ok)

@fangchenli
Copy link
Member Author

I suspect SQL related tests did not run in this build. Let me double check.

@fangchenli
Copy link
Member Author

The py38-slow build is not running any SQL tests. Doesn't it suppose to? If not, we could move it to Azure.

@jreback
Copy link
Contributor

jreback commented Dec 11, 2020

The py38-slow build is not running any SQL tests. Doesn't it suppose to? If not, we could move it to Azure.

umm, whereever we have sqlalchemy installed should run (if it ins't we should add)

@jreback
Copy link
Contributor

jreback commented Dec 11, 2020

i think the npdev build is fixed on master if you can merge master

@jreback
Copy link
Contributor

jreback commented Dec 27, 2020

can u merge master

@fangchenli
Copy link
Member Author

All those errors are related to dask/fastparquet#539. We need to either bump min fastparquet version to 0.4.0 or pin numba version to <0.52

@jreback
Copy link
Contributor

jreback commented Dec 27, 2020

All those errors are related to dask/fastparquet#539. We need to either bump min fastparquet version to 0.4.0 or pin numba version to <0.52

let's bump fastparquet & add a note in the whatsnew (do in 1.2.1 is fine)

.travis.yml Show resolved Hide resolved
@jreback jreback merged commit 4fe17a4 into pandas-dev:master Dec 27, 2020
@jreback
Copy link
Contributor

jreback commented Dec 27, 2020

thanks @fangchenli really monumental here. !

a couple of followon things if you can.

  • add the build versions printing for these 2 builds
  • for the -cov build. i know we are attempting to get coverage here, but anything we can remove / reduce here? e.g. it would make sense to split this into 2 builds one for slow and one for the fast. though we already have these covered (except for the slow / db things). so maybe can just call this a slow build and repurpose one of the azure builds (38 linux maybe) as a coverage build?

@jreback
Copy link
Contributor

jreback commented Dec 27, 2020

@meeseeksdev backport 1.2.x

@jbrockmendel
Copy link
Member

the 1.3.0 whatsnew still lists 0.3.2 as the minimum version for fasparquet. should this be updated?

@fangchenli
Copy link
Member Author

the 1.3.0 whatsnew still lists 0.3.2 as the minimum version for fasparquet. should this be updated?

just opened a new PR for that #40424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants