REGR: to_csv created corrupt ZIP files when chunksize<rows #38728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 28, 2020
pandas/io/common.py
Outdated
| ) | ||
| self.multiple_write_buffer.write(data) | ||
|
|
||
| def _write(self) -> None: |
There was a problem hiding this comment.
shouldn't this actually be called .flush()? or is that conflicting?
There was a problem hiding this comment.
I didn't think about that, flush might be a simpler solution! I will test that.
There was a problem hiding this comment.
I renamed it to flush, but we still have to overwrite close. Some tests (weirdly not all tests) were failing without overwriting close.
|
thanks @twoertwein very nice |
|
@meeseeksdev backport 1.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 29, 2020
…when chunksize<rows
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Dec 29, 2020
…size<rows (#38767) Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
3 tasks
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffWhen
ZipFile'swriteis called multiple times, it will create multiple files within the zip file (with the same filename).Edit: This also happens independently of
chunksizeas https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/writers.pyx#L14 callswriterowsmultiple times.