Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: aggregate always aggregates #40275

Closed
wants to merge 1 commit into from

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

Proof of concept to show what it would take for #35725 (needs tests, docs, and some comments cleaned up). I wanted to make sure the desired behavior has a viable path before deprecating. I'm planning to put up a PR to deprecate for #35725 in the next week or so, but since this seems to be a somewhat substantial behavior change, I'm wondering if it should be behind an option so that users can opt-in earlier and restore previous behavior for at least 1 release after the deprecation takes effect.

This makes any call to *.agg aggregate. For example:

 pd.DataFrame({'a': [1, 1], 'b': [2, 2]}).agg(lambda x: x)

will return a Series with 2 rows whose entries are Series themselves. On master, this would be a no-op. Some notes:

@rhshadrach rhshadrach added the Apply Apply, Aggregate, Transform, Map label Mar 6, 2021
@rhshadrach rhshadrach closed this Mar 15, 2021
@rhshadrach rhshadrach deleted the agg_always_aggs branch October 19, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map
Projects
None yet
1 participant