PERF: NDArrayBackedExtensionArray in cython #40840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Internals
jreback
approved these changes
Apr 14, 2021
| obj = cls._simple_new(arr, arr.dtype) | ||
|
|
||
| # for foo in [arr, dta, obj]: ... | ||
|
|
There was a problem hiding this comment.
nice, reproducible benchmarks!
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reboot of #40054, implements NDArrayBacked in a new arrays.pyx rather than in lib.pyx. The perf benefits have improved since #40054, as there is now the prospect of implementing a NDArrayBackedExtensionBlock in cython which will appreciably improve constructor and slicing performance.