BUG: DataFrame(floatdata, dtype=inty) does unsafe casting #41578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
May 20, 2021
jbrockmendel
commented
- closes BUG: DataFrame(ndarray, dtype=..) does unsafe conversion #26919
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
simonjayhawkins
added
Bug
Dtype Conversions
jreback
requested changes
May 21, 2021
| @@ -1207,6 +1206,19 @@ def astype_nansafe( | |||
| return arr.astype(dtype, copy=copy) | |||
|
|
|||
|
|
|||
| def astype_float_to_int_nansafe( | |||
There was a problem hiding this comment.
this is already done in astype_nansafe and IIRC in Index constructor as well. can you consolidate.
There was a problem hiding this comment.
this is already done in astype_nansafe
yes, this changes the call in astype_nansafe to use this new function, so that we can use this lighter-weight func in construct_1d_ndarray_preserving_na
and IIRC in Index constructor as well. can you consolidate.
similar but not identical (we also do it a third way for IntegerArray). some combination of #40489 and #40110 i think will make sharing feasible
There was a problem hiding this comment.
kk great. ok happy to merge here and do followsup.
jreback
approved these changes
May 21, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.