Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEB: Add benchmarks grant write up as a blog post #46483

Merged
merged 15 commits into from
Apr 7, 2022
Merged

WEB: Add benchmarks grant write up as a blog post #46483

merged 15 commits into from
Apr 7, 2022

Conversation

LucyJimenez
Copy link
Contributor

@LucyJimenez LucyJimenez commented Mar 23, 2022 •
edited by datapythonista
Loading

Closes #45049

Create a new entry on the blog for the asv-pandas grant.

@LucyJimenez LucyJimenez marked this pull request as draft March 23, 2022 10:58
@LucyJimenez LucyJimenez marked this pull request as ready for review March 24, 2022 02:18
@datapythonista
Copy link
Member

Thanks @LucyJimenez, I guess the CI problems are unrelated.

@dorothykiz1 can you have a look and make any comment if needed, and approve when it's ready please?

Did any of you render the website with this post to see if everything shows as expected?

@dorothykiz1
Copy link
Contributor

The errors don't seem related to the file added, let me render it first

@dorothykiz1
Copy link
Contributor

@LucyJimenez just added a few comments, you can take a look . The rendering of this post on a website is great.

@LucyJimenez
Copy link
Contributor Author

Thank you @datapythonista and @dorothykiz1.

@dorothykiz1 I am not able to see the comments yet. Could you please send it again?

@LucyJimenez
Copy link
Contributor Author

@datapythonista and @dorothykiz1 I included the comments, and the PR is ready for your review. Thanks!

@datapythonista
Copy link
Member

Can you merge master? I think CI should be green now.

@LucyJimenez
Copy link
Contributor Author

Can you merge master? I think CI should be green now.

Cool, I'll do it!

@LucyJimenez
Copy link
Contributor Author

@datapythonista the PR is ready to review. Thank you :)

datapythonista
datapythonista reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, mostly about capitalization and using hyphens that doesn't seem to make a lot of sense. If you can review that the final capitalization is consistent and makes sense, that would be great.

web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
web/pandas/community/blog/asv-pandas-grant.md Outdated Show resolved Hide resolved
@simonjayhawkins simonjayhawkins added the Web pandas website label Mar 29, 2022
@dorothykiz1
Copy link
Contributor

Thanks, @datapythonista for your comments ,I am learning from this.

@LucyJimenez
Copy link
Contributor Author

@datapythonista, I will include your suggestions and let you know when it is ready.

@LucyJimenez
Copy link
Contributor Author

@datapythonista, I included your suggestion in the blog. Please, take a look at it.

datapythonista
datapythonista approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @LucyJimenez and @dorothykiz1. I'll let someone else have another look. Make sure you leave the CI green, and you have a recent master merged into your branch.

@datapythonista datapythonista changed the title Add new post to pandas blog WEB: Add benchmarks grant write up as a blog post Apr 1, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 1, 2022
@mroeschke mroeschke merged commit 63c39a5 into pandas-dev:main Apr 7, 2022
@mroeschke
Copy link
Member

Thanks @LucyJimenez and @dorothykiz1, especially your contributions to ASV!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@LucyJimenez @yehoshuadimarsky
WEB: Add benchmarks grant write up as a blog post (pandas-dev#46483)
18c98d6 
* add new post to pandas blog

* update blog

* update blog

* remove whitespace

* fix title error

* update post content

* remove whitespace

* upadate with Dorothys comments

* remove .DS_Store files on local and fix typo

* include Marc suggestions

* update post

* change date and update url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Web pandas website
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Benchmarks grant
5 participants
@LucyJimenez @datapythonista @dorothykiz1 @mroeschke @simonjayhawkins