ENH: Make ExcelWriter & ExcelFile contextmanagers #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| engine to use by default via the options ``io.excel.xlsx.writer`` and | ||
| By default, ``pandas`` uses ``openpyxl`` for ``.xlsx`` and ``.xlsm`` files and | ||
| ``xlwt`` for ``.xls`` files. If you have multiple engines installed, you can | ||
| customize default engine to use via the options ``io.excel.xlsx.writer`` and | ||
| ``io.excel.xls.writer``. |
There was a problem hiding this comment.
how about we just link to the section on config options? Might keep things simpler.
|
nice! |
both can be used in with statements now. Makes it easier to use with multiple writers, etc. Plus touch up the docs on writers and such.
|
@cpcloud docs for this look okay? |
|
👍 |
jtratner
added a commit
that referenced
this pull request
Sep 23, 2013
ENH: Make ExcelWriter & ExcelFile contextmanagers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3441.
both can be used in with statements now. Makes it easier to use with multiple
writers, etc.
Plus touch up the docs on writers and such.