TST: Add regression test for NaN sparse columns #52772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ConnorMcKinley
commented
Apr 19, 2023
•
ConnorMcKinley
commented
- closes Filtering dataframe with sparse column leads to NAs in sparse column #27781
- Tests added and passed if fixing a bug or adding a new feature
mroeschke
reviewed
Apr 19, 2023
| # GH 27781 | ||
| df1 = pd.DataFrame({"A": SparseArray([0, 0, 0]), "B": [1, 2, 3]}) | ||
| df2 = pd.DataFrame({"A": SparseArray([0, 1, 0]), "B": [1, 2, 3]}) | ||
| result = df1.loc[df1["B"] != 2] |
There was a problem hiding this comment.
Can you also compare this to a manually created dataframe i.e.
expected = pd.DataFrame({...})
tm.assert_frame_equal(result, expected)
There was a problem hiding this comment.
Added it, thanks for the suggestion.
mroeschke
added
the
Testing
mroeschke
approved these changes
Apr 19, 2023
|
Thanks @ConnorMcKinley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.