Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: add mastodon links #52954

Merged
merged 2 commits into from
Apr 28, 2023
Merged

WEB: add mastodon links #52954

merged 2 commits into from
Apr 28, 2023

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Apr 27, 2023

Sidebar:
Screenshot from 2023-04-26 22-24-40

Footer:
image

@mroeschke mroeschke added the Web pandas website label Apr 27, 2023
@topper-123
Copy link
Contributor

/preview

@github-actions
Copy link
Contributor

No preview found for PR #52954. Did the docs build complete?

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mikix

Any reason to have this PR as a draft? Can it be merged already?

@datapythonista
Copy link
Member

/preview

There was a problem with the GitHub token and previews of the last couple of days aren't available. It should be fixed now, the preview for this PR should be available when the CI rerun finishes.

@mikix
Copy link
Contributor Author

mikix commented Apr 27, 2023

@datapythonista it could be, but I had some ideas around ordering:

In the api docs, the Twitter & mastodon links are currently in a different order than I put them on the web site. And the Twitter image is a (imo) distractingly bright blue — I was toying with unifying the order and appearance of the links in the api docs.

But it has been fairly difficult to build them!

Anyway, you can merge this if you like - I think it works OK — but I hadn’t just finished all my due diligence.

@datapythonista
Copy link
Member

Sure, no rush, I was just wondering if there was a reason.

If it makes your life easier, we can also merge this now and you can work on those in a separate PR. But surely fine to continue here if you prefer.

@datapythonista
Copy link
Member

/preview

@github-actions
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/52954/

@mikix
Copy link
Contributor Author

mikix commented Apr 28, 2023

Yeah you're right - this can be done incrementally - the current state is fine. I ran into another issue building the api docs, but I was able to confirm at least that the mastodon icon showed up. So this is good from my end. Will mark as ready.

@mikix mikix marked this pull request as ready for review April 28, 2023 11:50
@mroeschke mroeschke added this to the 2.1 milestone Apr 28, 2023
@mroeschke mroeschke merged commit 9fd0c74 into pandas-dev:main Apr 28, 2023
@mroeschke
Copy link
Member

Thanks @mikix

NumanIjaz pushed a commit to NumanIjaz/pandas that referenced this pull request May 1, 2023
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB: add links to the official mastodon account
4 participants