TYP: remove ignore from pandas/tseries/frequencies.py II #53120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
May 6, 2023
pandas/tseries/frequencies.py
Outdated
| if isinstance(index, Index) and not isinstance(index, DatetimeIndex): | ||
| if not hasattr(index, "dtype"): | ||
| pass | ||
| elif isinstance(index.dtype, object): |
There was a problem hiding this comment.
index.dtype is always an object
jbrockmendel
reviewed
May 7, 2023
pandas/tseries/frequencies.py
Outdated
| # "Union[ExtensionArray, ndarray[Any, Any]]", variable has type | ||
| # "Union[DatetimeIndex, TimedeltaIndex, Series, DatetimeLikeArrayMixin]") | ||
| index = index._values # type: ignore[assignment] | ||
| index = cast("TimedeltaArray", index._values) |
There was a problem hiding this comment.
this cant be right. TimedeltaIndex goes through the _TimedeltaFrequencyInferer path above
There was a problem hiding this comment.
Thank you for your comment. If I understand correctly, we only need to checkis_numeric_dtype(index.dtype)then.
There was a problem hiding this comment.
yep, looks like that should work.
There was a problem hiding this comment.
thank you for reviewing this pr.
|
thanks @natmokval |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
…53120) * remove mypy ignore[assignment] and cast index to TimedeltaArray * remove check index.dtype is an object * remove cast to TimedeltaArray
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…53120) * remove mypy ignore[assignment] and cast index to TimedeltaArray * remove check index.dtype is an object * remove cast to TimedeltaArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pr #52623, which doesn't work correctly.
mypy ignore[assignment] was removed from pandas/tseries/frequencies.py