Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump pandas-gbq to one that doesn't pin pyarrow #54200

Closed
wants to merge 8 commits into from

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 marked this pull request as draft July 19, 2023 23:05
@mroeschke
Copy link
Member

mroeschke commented Jul 19, 2023

Might be worth bumping the min version to https://github.com/googleapis/python-bigquery-pandas/releases/tag/v0.18.1 so users also don't get bit by pyarrow being pinned

@lithomas1 lithomas1 marked this pull request as ready for review July 20, 2023 00:53
@lithomas1
Copy link
Member Author

Ugh 0.18.1 isn't on conda-forge.

Is it fine to just go directly to 0.19.x?

@mroeschke
Copy link
Member

Ugh 0.18.1 isn't on conda-forge.

Is it fine to just go directly to 0.19.x?

Yeah that should be fine

@mroeschke mroeschke added Dependencies Required and optional dependencies Arrow pyarrow functionality labels Jul 21, 2023
@mroeschke
Copy link
Member

A few more places need bumping otherwise looks good

@lithomas1
Copy link
Member Author

Not entirely making sense of the error, but looks like there is a conflict between pyarrow dependencies
(aws-sdk-cpp) and google-bigquery dependencies(grpcio) fighting over openssl 1 and openssl 3.

I think what needs to happen is that we need to bump pyarrow from 7 to something newer.

PDEP-10 stops this from happening for 2.1, but maybe we can bump as soon as 2.2?
There seems to be no support plan in that PDEP, stopping us from bumping pyarrow as we please.

cc @jorisvandenbossche (this relates to the issue with pyarrow effectively being pinned on CI)

@lithomas1 lithomas1 added the Mothballed Temporarily-closed PR the author plans to return to label Jul 31, 2023
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Aug 31, 2023
@mroeschke
Copy link
Member

Going to close to clear the queue for now

@mroeschke
Copy link
Member

I think I may have tackled this in #55524?

@lithomas1 lithomas1 closed this Oct 23, 2023
@lithomas1
Copy link
Member Author

Nice, thanks Matt.

@lithomas1 lithomas1 deleted the bump-pandas-gbq branch October 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Dependencies Required and optional dependencies Mothballed Temporarily-closed PR the author plans to return to Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants