DEPR: Positional arguments in to_hdf except path_or_buf #54491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke Pinging on green |
mroeschke
reviewed
Aug 15, 2023
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -601,6 +601,7 @@ Other Deprecations | |||
| - Deprecated the use of non-supported datetime64 and timedelta64 resolutions with :func:`pandas.array`. Supported resolutions are: "s", "ms", "us", "ns" resolutions (:issue:`53058`) | |||
| - Deprecated values "pad", "ffill", "bfill", "backfill" for :meth:`Series.interpolate` and :meth:`DataFrame.interpolate`, use ``obj.ffill()`` or ``obj.bfill()`` instead (:issue:`53581`) | |||
| - Deprecated the behavior of :meth:`Index.argmax`, :meth:`Index.argmin`, :meth:`Series.argmax`, :meth:`Series.argmin` with either all-NAs and skipna=True or any-NAs and skipna=False returning -1; in a future version this will raise ``ValueError`` (:issue:`33941`, :issue:`33942`) | |||
| - Deprecated allowing non-keyword arguments in :meth:`DataFrame.to_hdf` except ``path_or_buf``. (:issue:`54229`) | |||
There was a problem hiding this comment.
Could you move this to v2.2.0.rst?
|
@mroeschke Pinging on green |
|
Thanks just a merge conflict otherwise looks good |
|
@mroeschke Merge conflict should be resolved now |
mroeschke
approved these changes
Aug 17, 2023
|
Thanks @rmhowe425 |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
…4491) * Adding deprecation, updating unit tests and documentation. * Fixing failing unit test. * Moving contribution to whatsnew/v2.2.0 * Update v2.1.0.rst
jbrockmendel
reviewed
Oct 6, 2023
| df = DataFrame([{"A": 1, "B": 2, "C": 3}, {"A": 1, "B": 2, "C": 3}]) | ||
|
|
||
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| df.to_hdf("example", "key") |
There was a problem hiding this comment.
this test is leaving behind an "example" file. can you do a follow-up to use tm.ensure_clean to avoid this
There was a problem hiding this comment.
@jbrockmendel sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.