Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Enforce deprecation of pinning name in SeriesGroupBy.agg #57671

Merged
merged 3 commits into from
Mar 5, 2024
Merged

CLN: Enforce deprecation of pinning name in SeriesGroupBy.agg #57671

merged 3 commits into from
Mar 5, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Ref: #51703

@rhshadrach rhshadrach added Groupby Clean Apply Apply, Aggregate, Transform, Map labels Feb 29, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Feb 29, 2024
datapythonista
datapythonista approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @rhshadrach

@datapythonista datapythonista added the Deprecate Functionality to remove in pandas label Feb 29, 2024
@rhshadrach
Copy link
Member Author

rhshadrach commented Mar 2, 2024 •
edited
Loading

@datapythonista - if you tag enforcements of deprecations as "Deprecate", our CI will add it to the list of deprecations to enforce in pandas 4.0. I think most are sticking to "Clean" for the enforcement.

@rhshadrach rhshadrach removed the Deprecate Functionality to remove in pandas label Mar 2, 2024
@rhshadrach rhshadrach mentioned this pull request Mar 2, 2024
Open
6 tasks
@datapythonista
Copy link
Member

Ah, thanks for the heads up, I forgot the bot.

@mroeschke mroeschke merged commit cec873e into pandas-dev:main Mar 5, 2024
45 of 47 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the enh_gb_agg_numeric_only branch March 5, 2024 00:46
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@rhshadrach @pmhatre1
CLN: Enforce deprecation of pinning name in SeriesGroupBy.agg (pandas…
48640dd 
…-dev#57671)

* CLN: Enforce deprecation of pinning name in SeriesGroupBy.agg

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Clean Groupby
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rhshadrach @datapythonista @mroeschke