Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix RT03, ES01 for pandas.core.groupby.DataFrameGroupBy.agg and pandas.core.groupby.DataFrameGroupBy.aggregate #59869

Conversation

tuhinsharma121
Copy link
Contributor

@tuhinsharma121 tuhinsharma121 commented Sep 22, 2024

fixes

pandas.core.groupby.DataFrameGroupBy.agg RT03, ES01
pandas.core.groupby.DataFrameGroupBy.aggregate RT03, ES01

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review September 22, 2024 08:53
@tuhinsharma121 tuhinsharma121 changed the title DOC: fix RT03, ES01 for pandas.core.groupby.DataFrameGroupBy.agg DOC: fix RT03, ES01 for pandas.core.groupby.DataFrameGroupBy.agg and pandas.core.groupby.DataFrameGroupBy.aggregate Sep 22, 2024
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pandas/core/groupby/generic.py Show resolved Hide resolved
@tuhinsharma121 tuhinsharma121 marked this pull request as draft September 26, 2024 05:58
tuhinsharma121 and others added 2 commits September 26, 2024 11:29
Co-authored-by: mroeschke <mroeschke@users.noreply.github.com>
Co-authored-by: mroeschke <mroeschke@users.noreply.github.com>
Co-authored-by: rhshadrach <rhshadrach@users.noreply.github.com>
@tuhinsharma121 tuhinsharma121 force-pushed the pandas.core.groupby.DataFrameGroupBy.agg branch from aa35a6f to bfb35a1 Compare September 26, 2024 06:02
@rhshadrach
Copy link
Member

This is looking good to me, but we'll need to wait until the CI gets fixed in order to ensure the docs build correctly.

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review September 28, 2024 18:05
@mroeschke mroeschke added the Docs label Sep 28, 2024
@mroeschke mroeschke added this to the 3.0 milestone Sep 28, 2024
@mroeschke mroeschke merged commit cf12e67 into pandas-dev:main Sep 28, 2024
55 checks passed
@mroeschke
Copy link
Member

Thanks @tuhinsharma121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants