BLD: Fix armv7 build #59906
Open
BLD: Fix armv7 build #59906
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Sep 27, 2024
WillAyd
reviewed
Sep 27, 2024
| #define PY_SSIZE_T_CLEAN | ||
| // clang-format off |
There was a problem hiding this comment.
I think you can remove these clang-format comments now too (I assume they were flagging the multiple includes of the header)
There was a problem hiding this comment.
Unfortunately not. clang-format changes the order of imports here, so without the comment the change would be reverted by pre-commit.
There was a problem hiding this comment.
Ah OK...that makes sense. Thanks.
I see CI is broken now but I believe that's unrelated
|
CI should be fixed - merge main to kickoff the builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.