Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC GH3508 (bis) added basic documentation of google analytics in remot... #8835

Closed
wants to merge 2 commits into from

Conversation

benoitpointet
Copy link
Contributor

added the GA doc to the correct file: "remote_data.rst"
closes #3508

@jreback
Copy link
Contributor

jreback commented Nov 17, 2014

actually if you would add a release note (in Enhancements) in v0.15.2, with a pointer to the docs (e.g. see here)....then people will know about the new docs.

thanks

@benoitpointet
Copy link
Contributor Author

Added entry in whatsnew for v15.0.2.

@jorisvandenbossche
Copy link
Member

For the rest, looks good to me!
Can you squash both commits into one?

@jreback
Copy link
Contributor

jreback commented Nov 17, 2014

merged via 9dd675b

thanks!

@jreback jreback closed this Nov 17, 2014
@jreback jreback mentioned this pull request Nov 17, 2014
@jreback
Copy link
Contributor

jreback commented Nov 17, 2014

@benoitpointet can you run this PR

#8785

and see if it removes the warnings that were previously generated.

lmk

@benoitpointet
Copy link
Contributor Author

Tested, it does indeed. It however does not remove the index_col bug described in #8773.

@jreback
Copy link
Contributor

jreback commented Nov 17, 2014

k thanks...

#8773 is not a bug, or did this use to work? (e.g. has the format changed)? The user needs to specify the index_col?

@benoitpointet
Copy link
Contributor Author

it used to work without​ having to provide the index_col argument.
b.

@jreback
Copy link
Contributor

jreback commented Nov 17, 2014

if you want to somehow infer that the index_col is 0 that would be great!

(e.g if index_col=None is the default), then just try it, if it fails, then you can try with index_col=0). IF its unambiguous.

Ideally would have tests for this.....

@benoitpointet
Copy link
Contributor Author

I'm unsure about hacking the read_ga function to infer such things.

If you look at the behaviour of the index_col param of the read_csv function for example, it support values such as index_col=['start', 'end'] or index_col=1. That for me should be the default behaviour of the index_col param in read_ga. I'm still having a hard time figuring out why it does not behave so ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google analytics docs
3 participants