-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spacing in admonitions #207
Conversation
OK I'm gonna merge this one in, since this is basically the implementation of the preview that @jorisvandenbossche +1'ed in #201 - I think it'll be easier to decide if we like the design after seeing it in action for a bit! |
Thanks! |
Hmm... Comparing to https://squidfunk.github.io/mkdocs-material/reference/admonitions/, given that both follow the same style, I think I prefer the full-width variant from mkdocs-material. Would it be OK to drop the |
Personally I would be fine with that, not sure if @choldgraf had a specific reason to add the padding |
I don't think I have a strong opinion here, was just trying to find ways to differentiate admonitions from the rest of the text because it felt visually cluttered to me, but happy to see what it looks like at 100 |
Hmm... Looks like I'll have to unbreak my npm setup to work on this project. |
What do you mean exactly? |
I'd borked my nvm / nodejs / brew installations a little while back and never fixed that trash fire because it was easier to step away and use Python-only tools. I don't think the development workflow here is difficult by any means. It's just that I made a mess that I have to clean up. 🙃 |
This adds spacing for admonitions.
Demo it here: https://370-130237506-gh.circle-artifacts.com/0/html/demo/demo.html#admonitions
closes #201