From d2a2d15e047210482f0877fd589474ac22a16807 Mon Sep 17 00:00:00 2001 From: Alexander Block Date: Fri, 10 May 2019 11:24:04 +0200 Subject: [PATCH] Print inputs on which we voted and quorums used for signing (https://github.com/dashpay/dash/pull/2907) * Print inputs on which we voted Also print the corresponding requestId. This makes debugging InstantSend issues easier. * Print quorum hash when signing a share * Remove unused nodesByAddress map in CSigSharesManager::SendMessages Not related to this PR, but a simple cleanup that should have no side effects. --- src/llmq/quorums_signing_shares.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/llmq/quorums_signing_shares.cpp b/src/llmq/quorums_signing_shares.cpp index 1a47dcaeab2f0..df69c3b6a3805 100644 --- a/src/llmq/quorums_signing_shares.cpp +++ b/src/llmq/quorums_signing_shares.cpp @@ -975,11 +975,6 @@ void CSigSharesManager::CollectSigSharesToAnnounce(std::unordered_map nodesByAddress; - g_connman->ForEachNode([&nodesByAddress](CNode* pnode) { - nodesByAddress.emplace(pnode->addr, pnode->GetId()); - }); - std::unordered_map> sigSharesToRequest; std::unordered_map> sigSharesToSend; std::unordered_map> sigSharesToAnnounce; @@ -1418,8 +1413,8 @@ void CSigSharesManager::Sign(const CQuorumCPtr& quorum, const uint256& id, const sigShare.UpdateKey(); - LogPrint(BCLog::LLMQ, "CSigSharesManager::%s -- signed sigShare. signHash=%s, id=%s, msgHash=%s, time=%s\n", __func__, - signHash.ToString(), sigShare.id.ToString(), sigShare.msgHash.ToString(), t.count()); + LogPrint(BCLog::LLMQ, "CSigSharesManager::%s -- signed sigShare. signHash=%s, id=%s, msgHash=%s, llmqType=%d, quorum=%s, time=%s\n", __func__, + signHash.ToString(), sigShare.id.ToString(), sigShare.msgHash.ToString(), quorum->params.type, quorum->pindexQuorum->GetBlockHash().ToString(), t.count()); ProcessSigShare(-1, sigShare, *g_connman, quorum); }