Add categorical colors #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- color mode can be switched between threshold (default/fallback) and categories - categories are based on the datapoint's locationName field
|
Dear Jonas, this is huge, thanks a bunch for your contribution and for taking the time to rebase your improvements on our fork. As you also touched the tests and added some more for covering the new features, I believe there's no reason to hesitate merging the improvements. I will try to merge them right away within the next iteration and cut a new release afterwards. With kind regards, |
…f colorMode is not set)
removed forgotten debug code
|
Dear Jonas, super sorry for the late reply. Several things have prevented me keeping up with maintenance. Now, after @robouden and @matschaffer slightly pushed me to release 0.10.0 (thanks again!), I will integrate your improvements and release 0.11.0 right away. With kind regards, |
|
The "pleasure" is ours. regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #20, we have decided to rebase our additions to the plugin on this fork, as it seems much more actively maintained and stable -- so first of all, thank you for providing this to the community.
This PR implements a simple approach to allow the circles to be colored by category (defined by their
Label-field) rather than numeric thresholds. The purpose of this feature is to allow the worldmap-panel to be used in situations where different objects are being tracked over time, rather than aggregating data for fixed locations.The code is modeled after the existing threshold approach, adding a dispatch layer where appropriate, which unfortunately also means it inherits its weaknesses (such as abusing
datafor the split thresholds and categories). This is certainly not ideal, but remodeling the whole settings-part in a backwards compatible way seemed to excessive for this small addition of functionality.