User registration #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
koffeinfrei
commented
Nov 23, 2018
•
koffeinfrei
commented
- user registration
- limit free subscription to 100 notes
- Show "welcome" note after registration
the location is not consumed by the client anymore, so we can fall back to the default implementation.
this way we can destroy a user
koffeinfrei
force-pushed
the
features/user-registration
branch
from
d7b5542
to
514bfea
Compare
koffeinfrei
force-pushed
the
features/user-registration
branch
from
514bfea
to
78f4ff6
Compare
koffeinfrei
force-pushed
the
features/user-registration
branch
from
9f63df8
to
f64c1d4
Compare
koffeinfrei
force-pushed
the
features/user-registration
branch
from
25c8a04
to
73bd6d7
Compare
macrozone
reviewed
Nov 26, 2018
client/src/RegistrationForm.js
Outdated
| const errors = responseJSON.errors.join('<br>'); | ||
|
|
||
| AlertFlash.show('Sorry, that did not work. You need to fix your inputs:<br>' + errors) | ||
| }); |
There was a problem hiding this comment.
if you want to have jquery-less solution you could do:
- instead of using serialize, you might get the data like in one of these approaches: https://stackoverflow.com/a/47678799
- personally, i always use controlled inputs where you define
valueandonChangefor every form field and save the values in a state. It's more work, but its somewhat more clear, because it does not rely on the browser-api and also works similarly on environments like react-native., see this answer: https://stackoverflow.com/a/23428536
for $.ajax you could use the new fetch-api which is native to all modern browser and can be polyfilled: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch
There was a problem hiding this comment.
personally, i always use controlled inputs
You're right, that's the proper way to do react.
for $.ajax you could use the new fetch-api
Dropping jquery is a midterm goal anyway, but I'll have to get rid of bootstrap first (hence, a redesign).
There was a problem hiding this comment.
@macrozone Updated in 64bb19c.
1. errors are out of the viewport, esp. on mobile 2. after registration, the welcome message is not visible
react doesn't send the value with controlled inputs if the field is left empty. that way the password confirmation is not needed and would create the user without it.
koffeinfrei
force-pushed
the
features/user-registration
branch
from
3af3695
to
fd059df
Compare
koffeinfrei
force-pushed
the
features/user-registration
branch
from
48e830b
to
9e30ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.