Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Deprecation Notices: Required parameter $section follows optional parameter $page #512

Closed
kshaner opened this issue Feb 22, 2022 · 1 comment
Closed

PHP 8 Deprecation Notices: Required parameter $section follows optional parameter $page #512

kshaner opened this issue Feb 22, 2022 · 1 comment
Milestone
2.2.6

Comments

@kshaner
Copy link
Contributor

kshaner commented Feb 22, 2022 •
edited
Loading

With WP_DEBUG on there are deprecation notices on front and back end:

PHP Deprecated:  Required parameter $section follows optional parameter $page in /var/www/wp-content/plugins/solr-power/includes/class-solrpower-options.php on line 589

Since it's a private method, and all usage seems to explicitly specify the $page, $section, and $type arguments, it would appear to be safe to specify a default value for $section and $page which gets rid of these deprecation notices.
@kshaner kshaner mentioned this issue Feb 22, 2022
Merged
@danielbachhuber danielbachhuber added this to the 2.2.6 milestone Feb 22, 2022
@danielbachhuber
Copy link
Contributor

🔨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.6
Development

No branches or pull requests
2 participants
@danielbachhuber @kshaner