Configurable local execution root for v2. #9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this could be controlled by exporting TMPDIR but that was both not discoverable in the standard way potentially did too much by both redirecting TMPDIR for pants as a whole as well as any processes it spawned and, as a side-effect, setting the local execution root. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests]
Eric-Arellano
approved these changes
May 7, 2020
There was a problem hiding this comment.
This is great. I'll replace https://pants.readme.io/docs/troubleshooting#using-an-alternative-tmpdir once this lands. Thanks!
stuhood
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this could be controlled by exporting TMPDIR but that was
both not discoverable in the standard way potentially did too much by
both redirecting TMPDIR for pants as a whole as well as any processes
it spawned and, as a side-effect, setting the local execution root.
[ci skip-jvm-tests]