Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate 'ath' claim in DPoP when access token is used #407

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

bifurcation
Copy link
Contributor

Fixes #406

According to draft-03 of DPoP:

   When the DPoP proof is used in conjunction with the presentation of
   an access token, see Section 7, the DPoP proof also contains the
   following claim:

   *  "ath": hash of the access token (REQUIRED).  The value MUST be the
      result of a base64url encoding (with no padding) the SHA-256 hash
      of the ASCII encoding of the associated access token's value.

The DPoP implementation in this repository currently does not provide the ath claim when used with an access token (e.g., in userinfo() and requestResource()). This PR updates the DPoP proof construction code so that if an access token is provided, then the ath parameter is included in the proof.

@bifurcation
Copy link
Contributor Author

I have also verified that this branch interoperates with node-oidc-provider, using the scripts linked in #406.

@panva panva merged commit 5565ee1 into panva:main Sep 20, 2021
@panva
Copy link
Owner

panva commented Sep 20, 2021

@bifurcation thank you for the PR, I've made a few small adjustments and will release a new minor (this is a feat, not a fix) shortly.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update DPoP to an updated draft
2 participants