Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): requestResource returns a Promise #546

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

roemba
Copy link
Contributor

@roemba roemba commented Nov 28, 2022

As I had also encountered the issue described in #488 and I saw that @panva requested a pull request, I hereby made a pull request fixing the issue.

Please let me know if you have any comments or feedback on the changes, I'll be happy to incorporate them.

@panva panva changed the title fix(typescript): add Promise to requestResource definition to reflect async nature fix(typescript): requestResource returns a Promise Nov 28, 2022
@panva panva merged commit 8bc9519 into panva:main Nov 28, 2022
@panva
Copy link
Owner

panva commented Nov 28, 2022

@roemba thank you

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants