fix(passport): ignore static state and nonce passed to Strategy() #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
reviewed
Jan 19, 2023
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
panva
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@panva: As discussed, this pull request ignores static
stateandnoncevalues that are passed to theStrategy()(a mis-use of the API). Ignoring them here allows them to be dynamically generated on eachauthenticate()for flows that require them.I also documented how to pass dynamic parameters to
authenticate()(in a separate commit, daa70a5, in case you aren't interested in this change).Note that this is a breaking change for users who are mis-using the API in this way if their Authorization Server requires a nonce or state for a flow where the spec does not require it.
Let me know if tests or anything else would be helpful.