refactor: avoid use of prototype attributes in keystore queries #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this library is run under environments which prohibit use of the deprecated __proto__ getter/setter, it may cause a crash due to reading from the __proto__ property. An example scenario is when the `--disable-proto=throw` flag is used for NodeJS. To disable consideration of the `prototype`, `__proto__`, and `constructor` fields fields when hashing, the `respectType` flag can be toggled off. This is not a problem for this library, as we are querying only for the existence of a object created via an object literal, which will have these properties all the same anyway.
|
If you're curious as to why I'm using that Node flag, I'm looking to migrate a codebase to Deno (which has removed the |
panva
changed the title
|
@pnappa thank you Patrick, though please note that this is a Node.js module and compatibility with Deno or other runtimes is not a goal. On the other hand https://github.com/panva/oauth4webapi is built using just Web runtime APIs, it is however a much lower level API. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library is run under environments which prohibit use of the deprecated
__proto__getter/setter, it may cause a crash due to reading from the proto property. An example scenario is when the--disable-proto=throwflag is used for NodeJS.To disable consideration of the
prototype,__proto__, andconstructorfields fields when hashing, therespectTypeflag can be toggled off. This is not a problem for this library, as we are querying only for the existence of a object created via an object literal, which will have these properties all the same anyway.