ci/cd: Use clippy to ensure code quality

[marhkb]

No description provided.

[melix99]

The fact that the clippy CI is not running on flatpak can be problematic, this is why I haven't merged this yet. I wonder if we can use the same flatpak instance for also running clippy.

[marhkb]

The fact that the clippy CI is not running on flatpak can be problematic, this is why I haven't merged this yet. I wonder if we can use the same flatpak instance for also running clippy.

I took a look at pika to see how they solved it. When I tried to port their solution over, I realized that it doesn't run clippy in the end at all, neither here nor in their pipeline (https://gitlab.gnome.org/World/pika-backup/-/jobs/1706197). So this is never going to fail.

In order to make clippy run, I had to make a small correction. I plan to contribute that to pika.

Additionally, I had to pass -Dwarnings to clippy to treat warnings as errors. In this way, the pipeline will fail if clippy complains. The disadvantage is that only the first warning (error) will be printed before clippy returns an exit code. IIUC, this should be fixed with the next rust release (rust-lang/rust-clippy#1209 (comment)).

One last thing I could not solve is to make flatpak-builder download the rust sdk extension automatically. Unfortunately, my research here was without success.

[melix99]

One last thing I could not solve is to make flatpak-builder download the rust sdk extension automatically. Unfortunately, my research here was without success.

I think we need --install-deps-from=flathub.

[marhkb]

One last thing I could not solve is to make flatpak-builder download the rust sdk extension automatically. Unfortunately, my research here was without success.

I think we need --install-deps-from=flathub.

That was it! I found that I either had to add the repo to the user installation additionally or simply remove the --user flag to make it work.
This should be complete now.