Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BlockchainProvider2 requests methods aware of in-memory state #10246

Closed
Tracked by #10186
Rjected opened this issue Aug 9, 2024 · 0 comments · Fixed by #10252
Closed
Tracked by #10186

Make BlockchainProvider2 requests methods aware of in-memory state #10246

Rjected opened this issue Aug 9, 2024 · 0 comments · Fixed by #10252
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database

Comments

@Rjected
Copy link
Member

Rjected commented Aug 9, 2024

Similar to #10181, the requests_by_block method only fetches from the database and does not check in-memory state:

reth/crates/storage/provider/src/providers/blockchain_provider.rs

Line 817 in 9b5a166

self.database.requests_by_block(id, timestamp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make RequestsProvider method aware of in-memory state lakshya-sky/reth
1 participant
@Rjected