Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend BuiltPayload type #10436

Closed
Tracked by #10435
mattsse opened this issue Aug 22, 2024 · 0 comments · Fixed by #10583
Closed
Tracked by #10435

Extend BuiltPayload type #10436

mattsse opened this issue Aug 22, 2024 · 0 comments · Fixed by #10583
Labels
S-blocked This cannot more forward until something else changes S-needs-design This issue requires design work to think about how it would best be accomplished

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024 •
edited
Loading

currently the BuiltPayload type returns the block:

reth/crates/payload/primitives/src/traits.rs

Lines 18 to 20 in a0a2f35

pub trait BuiltPayload: Send + Sync + std::fmt::Debug {
/// Returns the built block (sealed)
fn block(&self) -> &SealedBlock;

ideally this type should be required to also serve the receipts

this would be required so that this can be reused in RPC
@mattsse mattsse mentioned this issue Aug 22, 2024
Closed
@mattsse mattsse added S-blocked This cannot more forward until something else changes S-needs-design This issue requires design work to think about how it would best be accomplished labels Aug 22, 2024
@malik672 malik672 mentioned this issue Aug 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 31, 2024
@mattsse mattsse mentioned this issue Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-blocked This cannot more forward until something else changes S-needs-design This issue requires design work to think about how it would best be accomplished
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Extend BuiltPayload type malik672/reth
1 participant
@mattsse