Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TransactionInfo type for rpc transaction construction #10494

Closed
Tracked by #12576
mattsse opened this issue Aug 24, 2024 · 1 comment · Fixed by #10500
Closed
Tracked by #12576

Use TransactionInfo type for rpc transaction construction #10494

mattsse opened this issue Aug 24, 2024 · 1 comment · Fixed by #10500
Assignees
@SkandaBhat
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 24, 2024

Describe the feature

these function accept the blockcontext/txinfo as input:

reth/crates/rpc/rpc-types-compat/src/transaction/mod.rs

Lines 19 to 22 in a7a9f9f

block_hash: B256,
block_number: BlockNumber,
base_fee: Option<u64>,
tx_index: usize,

reth/crates/rpc/rpc-types-compat/src/transaction/mod.rs

Line 35 in a7a9f9f

fn fill(

we have a type for this: TransactionInfo: https://github.com/alloy-rs/alloy/blob/8a06509c3f85885ecfab110af0819b354d794b68/crates/rpc-types-eth/src/transaction/common.rs#L10-L10

TODO

  • use that type instead of individual fields

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 24, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Aug 24, 2024
@mattsse mattsse mentioned this issue Aug 24, 2024
Merged
@SkandaBhat
Copy link
Contributor

Please assign @mattsse!

@SkandaBhat SkandaBhat mentioned this issue Aug 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 24, 2024
@emhane emhane mentioned this issue Nov 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SkandaBhat SkandaBhat

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rpc): Use TransactionInfo instead of individual fields SkandaBhat/reth
2 participants
@SkandaBhat @mattsse