Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BlobAndProofV1 to alloy_eips #10788

Closed
mattsse opened this issue Sep 9, 2024 · 3 comments · Fixed by #10969
Closed

Move BlobAndProofV1 to alloy_eips #10788

mattsse opened this issue Sep 9, 2024 · 3 comments · Fixed by #10969
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 9, 2024

Describe the feature

for convenience this type BlobAndProofV1

https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc-types/src/lib.rs#L69-L69 blocked by

should be moved to alloy_eips crate blocked by #9723

for blob serialization we can use

https://github.com/alloy-rs/alloy/blob/4492c25f1a666881d18367dc47d0040fc05b17ae/crates/rpc-types-beacon/src/sidecar.rs#L104-L114

and also move to eips crate

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 9, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Sep 9, 2024
@mvares
Copy link
Contributor

mvares commented Sep 9, 2024

@mattsse, shouldn't this issue be moved to the alloy repository?

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 9, 2024

yeah, but we also need to use it here once release, so doesn't really matter

@0xkrane
Copy link
Contributor

0xkrane commented Sep 10, 2024

i can take a stab at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants