Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move maximum ExExManager capacity to a constant #11277

Closed
shekhirin opened this issue Sep 27, 2024 · 1 comment · Fixed by #11293
Closed

Move maximum ExExManager capacity to a constant #11277

shekhirin opened this issue Sep 27, 2024 · 1 comment · Fixed by #11293
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

// todo(onbjerg): rm magic number
let exex_wal = Wal::new(
config_container
.config
.datadir
.clone()
.resolve_datadir(config_container.config.chain.chain())
.exex_wal(),
)?;
let exex_manager = ExExManager::new(
exex_handles,
1024,
exex_wal,

This magic number 1024 on line 109 should be moved to a constant but not removed from the ExExManager::new arguments, so that we can still test the functionality of limiting the capacity.

1024 notifications in the buffer is 3.5 hours of mainnet blocks, or 17 minutes of 1-second blocks. It should be enough for any use-case, and we can make it configurable once there's a demand for that.

Additional context

No response

@shekhirin shekhirin added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-exex Execution Extensions labels Sep 27, 2024
@nkysg
Copy link
Contributor

nkysg commented Sep 27, 2024

may I take this?

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants