Improve tx type count observability in pool #11286
Labels
A-observability
Related to tracing, metrics, logs and other observability tools
A-tx-pool
Related to the transaction mempool
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
currently we're only tracking txs by pool, which means that these metrics only track non pending blob txs:
reth/crates/transaction-pool/src/metrics.rs
Lines 34 to 37 in 098018d
reth/crates/transaction-pool/src/pool/blob.rs
Line 12 in 098018d
hence these metrics aren't useful to monitor how many blob transactions are currently in the entire txpool.
we would like this for all transaction types
TODO
we can either try tracking this on a per tx operation basis or by checking the total list by doing a fold over all transactions in the pool, which is more expensive.
reth/crates/transaction-pool/src/pool/txpool.rs
Lines 930 to 931 in 098018d
tracking all tx ops is more complex, so imo we're okay with updating these metrics when we update the pool for now this should be accurate enough:
reth/crates/transaction-pool/src/pool/txpool.rs
Line 432 in 098018d
Additional context
No response
The text was updated successfully, but these errors were encountered: