race condition during fork detection

[mattsse]

Describe the feature

reth/crates/engine/tree/src/tree/mod.rs

Line 930 in b09734a

fn is_fork(&self, target_hash: B256) -> ProviderResult<bool> {

suffers from a race conditions here

reth/crates/engine/tree/src/tree/mod.rs

Lines 950 to 953 in b09734a

	// verify that the given hash is not already part of persisted canonical chain
	if self.provider.block_number(target_hash)?.is_some() {
	return Ok(false)
	}

if we're currently actively reorging on disk but haven't removed the corresponding block yet, then we would incorrectly categorize the block as a non-fork

scenario

a) 1 -> 2 -> 3 -> 4 -> 5
b) reorg to '2: triggers removal of blocks on disk 2
c) another reorg that makes 2 the new head again at which point we wouldn't detect 2 as a fork block (2' is canonical at this point)

Additional context

No response