Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify BlockWithSenders types #13747

Closed
mattsse opened this issue Jan 9, 2025 · 0 comments · Fixed by #13735
Closed

Unify BlockWithSenders types #13747

mattsse opened this issue Jan 9, 2025 · 0 comments · Fixed by #13735
Assignees
@mattsse
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 9, 2025

Describe the feature

we have two blockwithsenders types, one with a hash field, one without.

these can easily be unified by using a OnceLock for the seal, like:

reth/crates/ethereum/primitives/src/transaction.rs

Lines 261 to 263 in d0684cf

/// Transaction hash
#[serde(skip)]
pub hash: OnceLock<TxHash>,

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 9, 2025
@mattsse mattsse self-assigned this Jan 9, 2025
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Jan 9, 2025
@mattsse mattsse mentioned this issue Jan 9, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add SealedBlock in reth-primitives-traits paradigmxyz/reth
1 participant
@mattsse