Can't find primitives::SHANGHAI when building

[odyslam]

Describe the bug

It may belong to the REVM repo. 🤔

Steps to reproduce

• Use reth as a dependency on a rust project; track main
• run cargo check

Node logs

No response

Platform(s)

Mac (Apple Silicon)

What version/commit are you on?

No response

Code of Conduct

• I agree to follow the Code of Conduct

[rkrasiuk]

@odyslam do you have a separate revm dependency?

[odyslam]

@rkrasiuk negative. If we are confident it's something on my local project, let's close the issue, and I will debug it.

[rkrasiuk]

@odyslam no, this is us. we patched revm to master here

reth/Cargo.toml

Lines 45 to 46 in dc57fba

	revm = { git = "https://github.com/bluealloy/revm" }
	revm-primitives = { git = "https://github.com/bluealloy/revm" }

[onbjerg]

Cargo.lock pins revm to 8e6f4f26173a245d9c3c19fd2317cd8bfd1c56a9 which definitely has the constant available. Perhaps your project has it pinned differently in Cargo.lock? I'm not sure if patched crates propagate to dependents

[odyslam]

In my `Cargo.lock:

[[package]]
name = "revm"
version = "3.0.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "284747ad0324ed0e805dcf8f412e2beccb7a547fbd84f0607865001b8719c515"
dependencies = [
 "auto_impl 1.0.1",
 "revm-interpreter",
 "revm-precompile",
]

[rkrasiuk]

@onbjerg i'm not sure Cargo.lock is respected.
edit: look what i found rust-lang/cargo#8728
edit2: "Just to be clere a libraries Cargo.lock has no effect on resolution for a project that depends on that library. "

[odyslam]

So what's the best way forward @rkrasiuk ?

On my side, I could use a rev of reth before this issue was introduced. Might be acceptable depending on when the features I am using where introduced (mainly infra like the CLI and task manager)

[rkrasiuk]

@odyslam just copy the patch lines over to your Cargo.toml, that should work

[odyslam]

This did the trick ✌️ Thanks @rkrasiuk