Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend fork activation blocks data #7098

Closed
klkvr opened this issue Mar 11, 2024 · 11 comments
Closed

Extend fork activation blocks data #7098

klkvr opened this issue Mar 11, 2024 · 11 comments
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity

Comments

@klkvr
Copy link
Collaborator

klkvr commented Mar 11, 2024

Describe the feature

Extend https://github.com/paradigmxyz/reth/blob/main/crates/ethereum-forks/src/hardfork.rs with fork activation block numbers data for more chains.

This data is non-trivial to obtain, so comments/links to lists of hardfork->block mappings are appreciated as well even if you have no plans for creating a PR with those.

Especially useful would be data for Arbitrum and any other chains enabling Shanghai/Cancun support in the near future.

Additional context

No response

@klkvr klkvr added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 11, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Mar 11, 2024
@altugbakan
Copy link
Contributor

Can I work on this? Which chains would be beneficial to add?

@mattsse
Copy link
Collaborator

mattsse commented Mar 11, 2024

arbitrum would be great

@altugbakan
Copy link
Contributor

So, I’ve started doing some research. Are Arbitrum One and its testnet sufficient, or should we consider Arbitrum Nova and others?

@mattsse
Copy link
Collaborator

mattsse commented Mar 12, 2024

happy to accept all :)

up to you how much you'd like to do, but one+testnet would be sufficient

@altugbakan
Copy link
Contributor

Quick update: I've found the corresponding upgrades (ArbOS 11 for Shangai, ArbOS 20 Atlas for Cancun), but I could not find the actual blocks where the upgrade has happened. They have the update information here, but there is no information on the block number, just the date. I'm continuing my research, but if there are any tips you would like to give, I'm open to them.

@mattsse
Copy link
Collaborator

mattsse commented Mar 14, 2024

you can try cast find-block <timestamp> to find the block that corresponds to a timestamp

@gakonst
Copy link
Member

gakonst commented Mar 16, 2024

We don't support Arbitrum yet so not sure we should include this?

@klkvr
Copy link
Collaborator Author

klkvr commented Mar 16, 2024

We've discussed this in context of this being useful as a separate crate which we could also pull in as a foundry dep to address foundry-rs/foundry#6228 (comment) by determining spec for forked env.

Agreed that it'd be confusing to have arbitrum feature flag in any of Reth packages at this point

@mattsse wdyt?

@altugbakan altugbakan removed their assignment Jun 6, 2024
@mvares
Copy link
Contributor

mvares commented Jul 19, 2024

@mattsse think you should close this issue... (it's still in reth tracker)

Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 10, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-stale This issue/PR is stale and will close with no further activity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants