Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attohttpc as a dependency #7890

Closed
onbjerg opened this issue Apr 25, 2024 · 1 comment · Fixed by #9200
Closed

Remove attohttpc as a dependency #7890

onbjerg opened this issue Apr 25, 2024 · 1 comment · Fixed by #9200
Labels
A-dependencies Pull requests or issues that are about dependencies M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@onbjerg
Copy link
Member

onbjerg commented Apr 25, 2024

Describe the feature

attohttpc is required by reth-net-nat through igd-next which is used to find the machine's gateway over UPNP. We need to replace igd-next.

The only place it is used is here:

async fn resolve_external_ip_upnp() -> Option<IpAddr> {
search_gateway(Default::default())
.await
.map_err(|err| {
debug!(target: "net::nat", %err, "Failed to resolve external IP via UPnP: failed to find gateway");
err
})
.ok()?
.get_external_ip()
.await
.map_err(|err| {
debug!(target: "net::nat", %err, "Failed to resolve external IP via UPnP");
err
})
.ok()
}

Additional context

No response

@onbjerg onbjerg added the A-dependencies Pull requests or issues that are about dependencies label Apr 25, 2024
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 17, 2024
@onbjerg onbjerg removed the S-stale This issue/PR is stale and will close with no further activity label May 17, 2024
@Rjected Rjected added the M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity label May 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants