Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add returndata to transaction receipts where available #8079

Closed
charles-cooper opened this issue May 3, 2024 · 6 comments
Closed

add returndata to transaction receipts where available #8079

charles-cooper opened this issue May 3, 2024 · 6 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-blocked This cannot more forward until something else changes

Comments

@charles-cooper
Copy link

Describe the feature

per ethereum/execution-apis#542

Additional context

the proposed change to the api spec makes it optional to include returndata. the first implementation step could be to just add the returnData field with a value of nil, and then the second implementation step is to fill it in when it makes sense
@charles-cooper charles-cooper added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 3, 2024
@shekhirin shekhirin added S-blocked This cannot more forward until something else changes A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels May 3, 2024
@mattsse
Copy link
Collaborator

mattsse commented May 4, 2024

fill it in when it makes sense

when would this be the case?

@charles-cooper
Copy link
Author

from the perspective of the user, ideally, all the time - which would mean re-running the transaction or caching the returndata in a separate database. "when it makes sense" just means subject to performance constraints.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label May 26, 2024
@charles-cooper
Copy link
Author

Bump

@mattsse
Copy link
Collaborator

mattsse commented May 26, 2024

should this be eth_replayTransaction ?

@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels May 26, 2024
@mattsse
Copy link
Collaborator

mattsse commented Feb 5, 2025

closing as not planned until there's an EIP for an additional endpoint

@mattsse mattsse closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charles-cooper @shekhirin @mattsse