Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper conversion errors for OP tx variant #8777

Closed
mattsse opened this issue Jun 12, 2024 · 2 comments
Closed

Use proper conversion errors for OP tx variant #8777

mattsse opened this issue Jun 12, 2024 · 2 comments
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 12, 2024

Describe the feature

ref #8763

blocked by alloy-rs/alloy#875

TODO

  • use proper error variants here:

https://github.com/paradigmxyz/reth/blob/main/crates/primitives/src/alloy_compat.rs#L232-L233

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A clean up/refactor of existing code labels Jun 12, 2024
@emhane emhane removed the C-enhancement New feature or request label Jun 12, 2024
@PelleKrab
Copy link
Contributor

I can take this. Am I good to update alloy_compat.rs make a pr and then just wait for the Alloy version to be bumped?

@PelleKrab
Copy link
Contributor

nvm, it seems like this was already taken care of in #8763 37d51c4.

@mattsse mattsse closed this as completed Jun 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @emhane @PelleKrab