Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ots_getTransactionBySenderAndNonce #8905

Closed
mattsse opened this issue Jun 17, 2024 · 3 comments · Fixed by #9263
Closed

Implement ots_getTransactionBySenderAndNonce #8905

mattsse opened this issue Jun 17, 2024 · 3 comments · Fixed by #9263
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 17, 2024

Describe the feature

/// Gets the transaction hash for a certain sender address, given its nonce.
#[method(name = "getTransactionBySenderAndNonce")]
async fn get_transaction_by_sender_and_nonce(
&self,
sender: Address,
nonce: u64,
) -> RpcResult<Option<Transaction>>;

this should be very similar to #8638

and would likely require some additional provider trait functions that give access to the indexes + tracing

but we can start this by checking the pool:

/// Returns a transaction sent by a given user with a given nonce
fn get_transactions_by_sender_and_nonce(
&self,
sender: Address,
nonce: u64,
) -> Option<Arc<ValidPoolTransaction<Self::Transaction>>>;

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 17, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Jun 17, 2024
@mattsse mattsse changed the title Implement ots_g Implement ots_getTransactionBySenderAndNonce Jun 17, 2024
@PelleKrab
Copy link
Contributor

I can take this one.

@jsvisa
Copy link
Contributor

jsvisa commented Jul 2, 2024

Hi @PelleKrab, kindly ask are you been working on this feature, if not may I pick this?

@PelleKrab
Copy link
Contributor

Hi @PelleKrab, kindly ask are you been working on this feature, if not may I pick this?

Yeah, I have been working on it, but I have been busy, so feel free to take it. I got a little stuck on implementing the function into eth.rs, but I'm not sure if that is the correct approach. Let me know if you need any help.

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants