Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AllGenesisFormats #8999

Closed
mattsse opened this issue Jun 20, 2024 · 0 comments · Fixed by #9013
Closed

Remove AllGenesisFormats #8999

mattsse opened this issue Jun 20, 2024 · 0 comments · Fixed by #9013
Assignees
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 20, 2024

Describe the feature

this type doesn't make much sense

/// A helper type for compatibility with geth's config
#[derive(Debug, Clone, Deserialize, Serialize)]
#[serde(untagged)]
pub enum AllGenesisFormats {
/// The reth genesis format
Reth(ChainSpec),
/// The geth genesis format
Geth(Genesis),
}

and should be removed, the only supported input should be Genesis

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 20, 2024
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain and removed S-needs-triage This issue needs to be labelled labels Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants