Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Arc<KzgSettings> with alloy's EnvKzgSettings #9048

Closed
mattsse opened this issue Jun 24, 2024 · 2 comments · Fixed by #9054
Closed

replace Arc<KzgSettings> with alloy's EnvKzgSettings #9048

mattsse opened this issue Jun 24, 2024 · 2 comments · Fixed by #9054
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 24, 2024

Describe the feature

This can be replaced with alloy's EnvKzgSettings

reth/crates/transaction-pool/src/validate/eth.rs

Lines 437 to 438 in 42bbaff

/// Stores the setup and parameters needed for validating KZG proofs.
kzg_settings: Arc<KzgSettings>,

TODO

  • replace raw usage of Arc<KzgSettings> with alloy_eips::EnvKzgSettings

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-tx-pool Related to the transaction mempool labels Jun 24, 2024
@ochenane ochenane mentioned this issue Jun 24, 2024
Merged
@DaniPopes
Copy link
Member

cc #8063

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 24, 2024
@rakita
Copy link
Collaborator

rakita commented Jun 24, 2024

This removes a need for EnvKzgSettings ethereum/c-kzg-4844#443 as default can be easily added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change Arc<KzgSettings> to EnvKzgSettings ochenane/reth
3 participants
@rakita @mattsse @DaniPopes