Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make map_discv5_config_builder more ergonomic #9060

Closed
mattsse opened this issue Jun 24, 2024 · 1 comment · Fixed by #9143
Closed

make map_discv5_config_builder more ergonomic #9060

mattsse opened this issue Jun 24, 2024 · 1 comment · Fixed by #9143
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 24, 2024

Describe the feature

pub fn map_discv5_config_builder(

this call has been the root cause for this regression and is a bit confusing #9058 (comment)

ideally this function is removed and combined with the setter:

builder = builder.discovery_v5(reth_discv5::Config::builder(rlpx_socket));

bonus points for an additional test

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 24, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain A-networking Related to networking in general and removed S-needs-triage This issue needs to be labelled labels Jun 24, 2024
@yutianwu
Copy link
Contributor

Do u mean we remove the map function and use setters when we initialize the builder like this?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants