Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CLI runner in CLI trait #9139

Closed
Tracked by #7576
mattsse opened this issue Jun 27, 2024 · 1 comment · Fixed by #9146
Closed
Tracked by #7576

Integrate CLI runner in CLI trait #9139

mattsse opened this issue Jun 27, 2024 · 1 comment · Fixed by #9146
Assignees
Labels
A-cli Related to the reth CLI D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 27, 2024

in reth bin we do

let runner = CliRunner::default();

we can integrate this in the CLI crate with a helper function

pub trait RethCli: Sized {

eg:

fn with_runner(self, FnOnce(self, CliRunner)

can be combined with the parse function, like execute(FnOnce(Self, CliRunner))

@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-cli Related to the reth CLI labels Jun 27, 2024
@leruaa
Copy link
Contributor

leruaa commented Jun 27, 2024

I can take this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants