Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass ProviderFactory to segments instead of DatabaseProviderRW #9183

Closed
Tracked by #9181
emhane opened this issue Jun 28, 2024 · 2 comments
Closed
Tracked by #9181

Pass ProviderFactory to segments instead of DatabaseProviderRW #9183

emhane opened this issue Jun 28, 2024 · 2 comments
Labels
A-pruning Related to pruning or full node C-perf A change motivated by improving speed, memory usage or disk footprint S-wontfix This issue is the result of a deliberate design decision, and will not be fixed

Comments

@emhane
Copy link
Member

emhane commented Jun 28, 2024

Describe the feature

It's best to take a write lock as late as possible. Therefore, pruner should pass a reference to ProviderFactory to segments, instead of take the write lock before calling Segment::prune.

This is the first step in making it possible to take only a read lock on db in history pruning.

Additional context

No response
@emhane emhane added C-perf A change motivated by improving speed, memory usage or disk footprint A-pruning Related to pruning or full node labels Jun 28, 2024
This was referenced Jun 28, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 20, 2024
@shekhirin
Copy link
Collaborator

I believe it can be closed as not planned @emhane ?

@github-actions github-actions bot removed the S-stale This issue/PR is stale and will close with no further activity label Jul 23, 2024
@emhane emhane added the S-wontfix This issue is the result of a deliberate design decision, and will not be fixed label Jul 23, 2024
@emhane emhane closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-pruning Related to pruning or full node C-perf A change motivated by improving speed, memory usage or disk footprint S-wontfix This issue is the result of a deliberate design decision, and will not be fixed
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(pruner): pass ProviderFactory to segments paradigmxyz/reth
2 participants
@shekhirin @emhane