We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we have
reth/bin/reth/src/commands/p2p/mod.rs
Lines 37 to 40 in 068bf57
which conflicts with eth and ethereum
reth/crates/node/core/src/args/utils.rs
Lines 23 to 28 in 068bf57
this should be abstracted via a helper trait that a) defines the default supported traits as const b) defines a valueparser for the chainspec type
something like:
trait ChainSpecParser: TypedValueParser< Value = ChainSpec> + Default { const SUPPORTED_CHAINS : ... }
should be defined in crates/cli/cli crate
The text was updated successfully, but these errors were encountered:
Can I?
Sorry, something went wrong.
loocapro
Successfully merging a pull request may close this issue.
we have
reth/bin/reth/src/commands/p2p/mod.rs
Lines 37 to 40 in 068bf57
which conflicts with eth and ethereum
reth/crates/node/core/src/args/utils.rs
Lines 23 to 28 in 068bf57
this should be abstracted via a helper trait that
a) defines the default supported traits as const
b) defines a valueparser for the chainspec type
something like:
should be defined in crates/cli/cli crate
The text was updated successfully, but these errors were encountered: