Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replacing rpc handlers #9798

Closed
mattsse opened this issue Jul 25, 2024 · 4 comments · Fixed by #10497
Closed

Support replacing rpc handlers #9798

mattsse opened this issue Jul 25, 2024 · 4 comments · Fixed by #10497
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 25, 2024

Describe the feature

ref #8294

this will be possible once we bump jsonrpsee and can be integrated into the RpcContext type

/// The hook that is called once the rpc server is started.
fn extend_rpc_modules(self: Box<Self>, ctx: RpcContext<'_, Node, EthApi>) -> eyre::Result<()>;
}

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jul 25, 2024
@g4titanx
Copy link

g4titanx commented Aug 6, 2024

hi @mattsse, i would love to work on this

@mattsse
Copy link
Collaborator Author

mattsse commented Aug 6, 2024

cool, this should be possible now by adding some remove functions on

impl TransportRpcModules {

see also RpcModule::remove_method

@SkandaBhat
Copy link
Contributor

Hey @mattsse @g4titanx if there has been no activity on this, could I pick it up?

@mattsse mattsse assigned SkandaBhat and unassigned g4titanx Aug 22, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Aug 22, 2024

this should be available now with jsonrpsee 0.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants