diff --git a/Cargo.toml b/Cargo.toml index a1a21da331e1..34f1b65dada2 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -213,6 +213,7 @@ unused_rounding = "warn" use_self = "warn" useless_let_if_seq = "warn" zero_sized_map_values = "warn" +option_as_ref_cloned = "warn" # These are nursery lints which have findings. Allow them for now. Some are not # quite mature enough for use in our codebase and some we don't really want. diff --git a/crates/storage/db/src/implementation/mdbx/cursor.rs b/crates/storage/db/src/implementation/mdbx/cursor.rs index e2afbe0c16c7..c908bad45942 100644 --- a/crates/storage/db/src/implementation/mdbx/cursor.rs +++ b/crates/storage/db/src/implementation/mdbx/cursor.rs @@ -53,7 +53,7 @@ impl Cursor { value_size: Option, f: impl FnOnce(&mut Self) -> R, ) -> R { - if let Some(metrics) = self.metrics.as_ref().cloned() { + if let Some(metrics) = self.metrics.clone() { metrics.record_operation(T::NAME, operation, value_size, || f(self)) } else { f(self) diff --git a/crates/storage/db/src/implementation/mdbx/mod.rs b/crates/storage/db/src/implementation/mdbx/mod.rs index cc9f055e9533..aff1da56d68a 100644 --- a/crates/storage/db/src/implementation/mdbx/mod.rs +++ b/crates/storage/db/src/implementation/mdbx/mod.rs @@ -147,7 +147,7 @@ impl Database for DatabaseEnv { fn tx(&self) -> Result { Tx::new_with_metrics( self.inner.begin_ro_txn().map_err(|e| DatabaseError::InitTx(e.into()))?, - self.metrics.as_ref().cloned(), + self.metrics.clone(), ) .map_err(|e| DatabaseError::InitTx(e.into())) } @@ -155,7 +155,7 @@ impl Database for DatabaseEnv { fn tx_mut(&self) -> Result { Tx::new_with_metrics( self.inner.begin_rw_txn().map_err(|e| DatabaseError::InitTx(e.into()))?, - self.metrics.as_ref().cloned(), + self.metrics.clone(), ) .map_err(|e| DatabaseError::InitTx(e.into())) }